Cellular Network Infrastructure » Core Network (CN) » OsmoMSC

looking at gsm_04_08.c I find

        lu_fsm = vlr_loc_update(conn->conn_fsm,
                                [...]
                                is_utran || conn->network->authentication_required,
                                is_utran? VLR_CIPH_A5_3
                                        : conn->network->a5_encryption,
                                );

and I'm a bit puzzled on how this could have come about. It was added as part of the commit "Implement IuCS (large refactoring and addition)" and may have slipped by as an early and/or confused development state. It's obviously wrong. The patch to fix is trivial (just remove the conditional, use conn->network->a5_encryption directly), but it makes sense to build some tests around it as well. Thinking of msc_vlr_test_umts_authen.c to make sure auth without ciph works on UTRAN.

this probably dates back to my early confusion about the topic. I probably just wrote it down from a vague hunch and no-one reviewed it later.

neels, is this still an issue with the current msc code base? If yes, feel free to fix or assign to osmith

should be done in a few hours, so throwing this in now

https://git.osmocom.org/osmo-msc/commit/?id=a4d7a7681696723ce8128bc0f039a354d1f001ab
https://gerrit.osmocom.org/c/osmo-msc/+/15022