Project

General

Profile

Actions

Bug #4887

closed

ns2: Missing unittests

Added by daniel over 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
libosmogb
Target version:
-
Start date:
12/02/2020
Due date:
% Done:

100%

Spec Reference:

Description

We are missing tests for ns2 under tests/

We should also test the VTY for ns2 to catch issues such as https://gerrit.osmocom.org/c/libosmocore/+/21459 before they get merged.


Related issues

Related to libosmocore - Bug #5006: NS2: Wrong state for NSVC that never comes upClosedlynxis02/03/2021

Actions
Actions #1

Updated by laforge over 3 years ago

  • Assignee set to lynxis
Actions #2

Updated by laforge over 3 years ago

  • Priority changed from Normal to High

We've now seen this again in https://gerrit.osmocom.org/c/libosmocore/+/21741 and https://gerrit.osmocom.org/c/libosmocore/+/21742/1 whic both caused failures only in the osmo-pcu tests, but not in libosmocore itself.

Actions #3

Updated by lynxis over 3 years ago

  • Status changed from New to In Progress
Actions #4

Updated by lynxis over 3 years ago

  • Status changed from In Progress to Stalled
  • % Done changed from 0 to 30

The vty tests has been implmented.

Actions #5

Updated by daniel about 3 years ago

  • Related to Bug #5006: NS2: Wrong state for NSVC that never comes up added
Actions #6

Updated by daniel about 3 years ago

See https://gerrit.osmocom.org/c/libosmocore/+/22878

The issue was that we aren't actually testing ns2 config if there are no binds/nse configured.

https://gerrit.osmocom.org/c/libosmocore/+/22879 tries to fix that

Actions #7

Updated by lynxis about 3 years ago

  • Status changed from Stalled to Resolved
  • % Done changed from 30 to 100

There are now vty tests and also a couple unit tests.

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)