Actions
Bug #3637
openhandover decision 2: properly check available codecs
Start date:
10/09/2018
Due date:
% Done:
0%
Spec Reference:
Description
in handover_decision_2.c, I'm fairly sure we should have more than this for speech codec checks:
static bool codec_type_is_supported(struct gsm_subscriber_connection *conn,
enum gsm0808_speech_codec_type type)
{
int i;
struct gsm0808_speech_codec_list *clist = &conn->codec_list;
if (!conn->codec_list.len) {
/* We don't have a list of supported codecs. This should never happen. */
LOGPHOLCHAN(conn->lchan, LOGL_ERROR,
"No Speech Codec List present, accepting all codecs\n");
return true;
}
for (i = 0; i < clist->len; i++) {
if (clist->codec[i].type == type)
return true;
}
LOGPHOLCHAN(conn->lchan, LOGL_DEBUG, "Codec not supported by MS or not allowed by MSC: %s\n",
gsm0808_speech_codec_type_name(type));
return false;
}
Testing with SCCPlite, I also get above "this should never happen".
Compare match_codec_pref() which checks a lot more than just the gsm0808 SCL.
Related issues
Actions
