Bug #6130
closedFeature #5500: MS-Side GPRS RLC/MAC implementation
modem: Fix Submitting CCCH_DATA.ind with hardcoded fn=0 to libosmo-gprs-rlcmac
100%
Description
Right now osmocom-bb's modem app is submitting a hardcoded fn=0 to the RLC/MAC layer when submitting CCCH-DATA.ind:
static int forward_to_rlcmac(struct osmocom_ms *ms, struct msgb *msg) { struct osmo_gprs_rlcmac_prim *rlcmac_prim; /* Forward SI13 to RLC/MAC layer */ rlcmac_prim = osmo_gprs_rlcmac_prim_alloc_l1ctl_ccch_data_ind(0 /* TODO: fn */, msgb_l3(msg)); return osmo_gprs_rlcmac_prim_lower_up(rlcmac_prim); }
This is of course wrong and has to be fixed to provide the current FN from the scheduler, since RLC/MAC needs it for instance when receiving a CCCH ImmAss[PktUlAss[SingleBlkAlloc]] which contains an RFN, and which hence needs to be transformed to an absolute fn using curr_fn + rfn.
Related issues
Updated by pespin 9 months ago
This commit needs this feature in order to work:
https://gerrit.osmocom.org/c/libosmo-gprs/+/34046 rlcmac: ul_tbf: Implement TBF_Starting time (phase1)
The case can be easily tested by forcing osmo-pcu to use 2-phase acces (VTY config "two-phase-access").
Updated by pespin 9 months ago
- Status changed from New to Feedback
- % Done changed from 0 to 90
This is being fixed here: https://gerrit.osmocom.org/c/osmocom-bb/+/34133/6
Once merged this ticket can be closed.