Actions
Bug #3129
closedRRLP support is broken: signals are not being registered
Start date:
03/31/2018
Due date:
% Done:
100%
Resolution:
worksforme
Spec Reference:
Description
While reading the source code, I've found that we have:
void on_dso_load_rrlp(void) { osmo_signal_register_handler(SS_SUBSCR, subscr_sig_cb, NULL); osmo_signal_register_handler(SS_PAGING, paging_sig_cb, NULL); }
but don't call it anywhere, according to `git grep on_dso_load_rrlp`:
include/osmocom/msc/rrlp.h:void on_dso_load_rrlp(void); src/libmsc/rrlp.c:void on_dso_load_rrlp(void) { ... }
Updated by fixeria about 6 years ago
Also, probably it would make sense to rename the symbol to sth. like:
msc_rrlp_init();
because we don't actually deal with DSO loading here...
Updated by fixeria almost 6 years ago
- Category set to RRLP
- Status changed from New to Feedback
- Assignee set to fixeria
- % Done changed from 0 to 90
- Resolution set to worksforme
A fix has been submitted: https://gerrit.osmocom.org/10339/
I have also manually tested, and now OsmoMSC sends the position request if configured to do so.
Updated by fixeria over 5 years ago
- Status changed from Feedback to Resolved
- % Done changed from 90 to 100
Merged, tested - works fine now.
Actions